KarpelesLab / goro / 26359939529

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower $obj->$var property read natively (drop OpClassConst fallback)

The dollar-prefix form parses to runObjectVar with varName="$x" where
the property name comes from local variable $x at runtime. Restoring
the AST-delegation branch in 37b41488 fixed the regression but the form
is structurally identical to the curly-brace dyn-var read once the name
is evaluated.

Lower it natively: strip the leading $, emit OP_LOAD_LOCAL for the
name local, then OP_OBJECT_DYN_GET (same opcode that handles
$obj->{$expr}). Nullsafe flag encoding (A bit 0) preserved.

The $obj->$f(args) call form (runObjectFunc with op="$x") stays
AST-delegated for now; it's rare and the helper signature would need a
type-generic node parameter.

Smoke tests pass for: assign_obj_op_cache_slot, access_modifiers_011,
literal $obj->$x reads, $obj->$m() calls (unchanged).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

5 of 15 new or added lines in 1 file covered. (33.33%)

1 existing line in 1 file now uncovered.

14759 of 118275 relevant lines covered (12.48%)

2584.77 hits per line