KarpelesLab / goro / 26390158551

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower $obj->prop ?? default natively via OP_OBJECT_GET_SAFE

Currently $obj->prop ?? default routes through OpClassConst (generic
AST.Run delegation) because the AST's coalesce handler suppresses the
"Undefined property" warning that OP_OBJECT_GET would emit.

Add OP_OBJECT_GET_SAFE that calls ZObject.ObjectGetQuiet (already
exists) for ZtObject receivers — same dispatch as OP_OBJECT_GET but
silences the missing-property warning. Non-object receivers fall
through to the loud objectGet path; the coalesce LHS swallows any
resulting warning at the AST evaluation level, matching baseline.

emit_expr.go: emitCoalesce detects objectVarNode LHS with literal
(non-dollar-prefixed) name and emits OP_OBJECT_GET_SAFE instead of
OP_OBJECT_GET. Dollar-prefix form ($obj->$x) falls through to AST.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

21 of 56 new or added lines in 3 files covered. (37.5%)

5 existing lines in 3 files now uncovered.

14775 of 118331 relevant lines covered (12.49%)

2583.56 hits per line