KarpelesLab / goro / 26359880593

12%

push

github

vm: restore $obj->$var dollar-prefix AST-delegation (fix 7742c3b2)

7742c3b2 incorrectly removed the `name[0] == '$'` branches in
emitObjectVarRead and emitObjectFuncCall, claiming they were dead code.
They are NOT dead — the parser distinguishes two dynamic-property
forms:

  $obj->{$x}   parses to runObjectDynVar / runObjectDynFunc  (curly braces)
  $obj->$x     parses to runObjectVar / runObjectFunc with the literal
              dollar-prefixed token ("$x") as the name

The first form is intercepted by IsObjectDynVarReadNode /
IsObjectDynFuncNode earlier in the pipeline. The second form reaches
emitObjectVarRead / emitObjectFuncCall with a name like "$x" that
needs runtime variable lookup.

Restore both AST-delegation branches with the correct rationale in the
comments. Fixes regressions:
  access_modifiers/access_modifiers_011.phpt
  assign_obj_op_cache_slot.phpt

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

14 of 36 new or added lines in 1 file covered. (38.89%)

14759 of 118270 relevant lines covered (12.48%)

2584.88 hits per line