KarpelesLab / goro / 26359832605

12%

push

github

vm: lower runObjectDynFunc receiver + name eval natively (Stage 2)

OP_OBJECT_DYN_CALL previously took an AST node index and called
EvalObjectDynFunc, which ran the entire runObjectDynFunc.Run body
including .Run() on the receiver and name expressions.

Stage 2 splits the helper into two parts:
  - runObjectDynFuncDispatch: the post-evaluation dispatch (static /
    instance / __call / __callStatic) shared by both code paths.
  - EvalObjectDynFuncWithEvaluated: takes pre-evaluated receiver + name
    ZVals and delegates to the dispatch.

The VM emit now pushes receiver and name to the stack (native opcodes
with slot fast-paths), then OP_OBJECT_DYN_CALL pops both and calls the
WithEvaluated helper. Args are still looked up from the AST node and
bound via ctx.Call so by-ref / named / spread continue to work.

Stack delta: pops 2, pushes 1. Net: -1.

Smoke tests pass for: instance dyn-method, nullsafe null short-circuit,
static dyn-method (Foo::{$cn}()), __call magic fallback, named-arg via
indirect call.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

0 of 46 new or added lines in 4 files covered. (0.0%)

14755 of 118244 relevant lines covered (12.48%)

2585.44 hits per line