sgobotta / live_dj / f93f6855ebc9b4be35660a92600e4b3d8c05a240
49%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 74
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 50.385% (-0.5%) from 50.876%
f93f6855ebc9b4be35660a92600e4b3d8c05a240

push

github

web-flow 
Shareable room URL, persistent volume, and player stability fixes (#124)

* Standardize header alignment across home, rooms, and session pages

Use a three-column grid in app and session layouts so the logo stays
centered regardless of theme toggle and avatar placement. Move the
theme toggle to the left column and keep the user avatar on the right.
Add a theme toggle to the home page and relocate the version pill to
the bottom-left on app pages.

* Update room list title wording

* Redirect to rooms when clicking on session header

* Update create room modal

* Persist volume selection

* Update playlist background color

* Add welcome message with shareable URL

* Fix YouTube player being destroyed when toggling share modal

  Move the modal and video player out of the room LiveView template
  into the session layout so they live in separate diff slots from
  @inner_content. The player container is now a sticky PlayerLiveView
  in the layout, shielded from re-renders caused by live_action changes.

  Also guard on_player_container_mount and on_player_loaded against
  double-initialization (is_nil player check), trigger player mount
  from the hook's mounted() instead of phx-mounted, use stable static
  IDs instead of per-mount UUIDs, and remove overflow-hidden body
  manipulation from show_modal/hide_modal which caused a scrollbar
  width shift that made the YouTube iframe flicker on modal open.

* Playlist: margin adjustment

786 of 1560 relevant lines covered (50.38%)

18.32 hits per line

Coverage Regressions

Lines Coverage ∆ File
27
0.0
 0.0% //lib/livedj_web/live/sessions/room_live/show.ex
23
0.0
 0.0% //lib/livedj_web/live/player_controls_live.ex
22
0.0
 0.0% //lib/livedj_web/live/sessions/room_live/form_component.ex
8
7.3
 -0.39% //lib/livedj/sessions.ex
1
82.98
 0.0% //lib/livedj_web/components/core_components.ex
1
70.59
 -4.41% //lib/livedj_web/router.ex
Jobs
ID Job ID Ran Files Coverage
1 f93f6855ebc9b4be35660a92600e4b3d8c05a240.1 74
50.38
 GitHub Action Run
Source Files on build f93f6855ebc9b4be35660a92600e4b3d8c05a240