dangernoodle-io / breadboard / 26153840453

100%

push

github

refactor: bundled mechanical cleanups (audit 1.2, 1.3, F15, F18, F21, 8.1) (#286)

* refactor: bundled mechanical cleanups (audit 1.2, 1.3, F15, F18, F21, 8.1)

- move mid-file #includes to file top in bb_nv.c, bb_mdns.c, bb_ota_pull.c, bb_ota_push.c (audit 1.3)
- replace ESP_LOG* with bb_log_* in bb_json_cjson.c, bb_led_pwm.c, bb_log_routes.c (audit 1.2)
- rename duplicate TAGs: bb_manifest → bb_manifest_routes/bb_manifest_emit; bb_openapi → bb_openapi_routes/bb_openapi_emit (audit F21)
- replace strncpy with copy_str() in bb_nv_config_set_wifi and bb_nv_config_set_hostname (audit F15)
- move TOPIC_NAME literal to BB_UPDATE_CHECK_TOPIC macro in bb_update_check_internal.h; use in both common.c and bb_update_check_espidf.c (audit F18)
- add one-time bb_log_w on first call to host bb_mdns stubs; add bb_log_w in Arduino bb_event_routes lock init (audit 8.1/8.2)
- add 4 tests covering first-call/subsequent-call branches for s_warned in bb_mdns_host.c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: add bb_log to bb_json PRIV_REQUIRES for esp32c3 smoke

bb_json_cjson.c calls bb_log_* after PR-F migration from ESP_LOG*,
but bb_log was not listed in bb_json's CMakeLists — causing a missing
header error on esp32c3 smoke.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1026 of 1026 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1899 of 1899 relevant lines covered (100.0%)

956.48 hits per line