dangernoodle-io / breadboard / 26144239929

100%

push

github

fix: unify firmware-board fallback and delegate mark-valid (F16, audit 7.3) (#285)

- remove bb_ota_pull_set_firmware_board() and s_firmware_board from
  bb_ota_pull; ota_fetch_manifest now reads the board from
  bb_update_check_get_status().board — bb_update_check is the single
  source of truth for the configured board name
- expose board field on bb_update_check_status_t so callers can inspect
  the effective board name ("unknown" when unset)
- change BOARD_NAME_FALLBACK in bb_update_check from "firmware" to
  "unknown" to match bb_ota_pull's existing fallback; both components
  now agree on a single fallback string
- bb_ota_mark_valid() delegates to mark_valid_internal() so the atomic
  exchange guard runs in exactly one place (audit 7.3)
- update tests: add explicit bb_update_check_set_firmware_board("firmware")
  where tests relied on the old fallback; add 3 new tests for
  get_status.board; fix two clears-to-default tests to use UNKNOWN_BODY
- fix bb_event_port_reset_for_test: signal and join the dispatcher thread
  before destroying the mutex/condvar to prevent CI hangs on Linux (UB
  per POSIX when pthread_cond_destroy is called while a thread is blocked
  in pthread_cond_wait)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1026 of 1026 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

1899 of 1899 relevant lines covered (100.0%)

954.74 hits per line