KarpelesLab / goro / 26066643505

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: iterative FuncContext.Loc + revert NoDiscard native emit

FuncContext.Loc walked the parent chain recursively; a context-pool
aliasing bug can make that chain cyclic, overflowing the goroutine
stack (observed on the bug73156 eval + debug_backtrace path). Loc is
now iterative with a 64K-frame depth cap — well past PHP's 4096
nesting limit — so a cycle bails to the frame's own call-site loc
instead of crashing the process.

Also reverts the native NoDiscard emit again: it regressed
native-method NoDiscard detection (DateTimeImmutable::setTimestamp).
NoDiscard stays AST-delegated; the helpers remain for the AST runner.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

16 of 19 new or added lines in 3 files covered. (84.21%)

39 existing lines in 7 files now uncovered.

14416 of 117018 relevant lines covered (12.32%)

2563.96 hits per line