KarpelesLab / goro / 26066449413

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: fix constant loc, mbConvert cyclic recursion, re-enable NoDiscard

Three fixes:

- emit_expr.go: OP_LOAD_CONSTANT_BY_NAME now records the constant's
  own source loc before the opcode, so an "Undefined constant" Error
  reports the exact line (fixes exceptions/exception_026 — a line
  off-by-one introduced by the runConstant lowering).

- mbstring.go: mbConvertEncodingArray gained a visited-set so a
  self-referential array no longer overflows the stack — same fix
  shape as findFirstString.

- emit_stmt.go: re-enables the native OP_NODISCARD_ENTER/EXIT bracket
  emit. The earlier revert blamed it for a CI stack overflow, but the
  real cause was the mbstring cyclic-array recursion; with that fixed
  the NoDiscard lowering is sound.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

10 of 24 new or added lines in 3 files covered. (41.67%)

11 existing lines in 1 file now uncovered.

14435 of 117008 relevant lines covered (12.34%)

2564.29 hits per line