KarpelesLab / goro / 26067127795

13%

push

github

ext/mbstring: detect recursion in mb_convert_variables

mbConvertVariableInPlace now returns a recursed flag when it walks
into a self-referential array. fncMbConvertVariables emits the
"Cannot handle recursive references" warning and returns false —
matching PHP (bug66964).

The cycle is detected on the original element's underlying ZArray
before Dup (Dup of a ref-to-array clones the array, which would
defeat a pointer-identity check on the copy).

Fixes the 7 mbstring bug* tests that previously crashed the suite
via stack overflow and then surfaced as plain failures once the
overflow was guarded.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

0 of 30 new or added lines in 1 file covered. (0.0%)

51395 of 117035 relevant lines covered (43.91%)

26483.48 hits per line