KarpelesLab / goro / 26066024770

13%

push

github

ext/mbstring: fix infinite recursion in findFirstString on cyclic arrays

PHP arrays can hold references to themselves (e.g.
\`\$a = []; \$a[] = &\$a;\`). The previous traversal recursed into
each element unconditionally and overflowed Go's goroutine stack
when given such a cycle — the trigger was a particular mb_convert_*
test variant.

Added a visited-set parameter (same shape as
compile-unset.go's callDestructorIfNeededVisited).

Note: the overflow was the root cause of the CI cascades observed
in the recent NoDiscard / static var / VarVarRead lowering CIs —
the lowerings shifted memory pressure so the overflow hit earlier.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

0 of 11 new or added lines in 1 file covered. (0.0%)

14409 of 116997 relevant lines covered (12.32%)

2564.23 hits per line