KarpelesLab / goro / 26064738319

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower \$\$name / \${expr} variable-variable reads natively

Adds OP_VAR_VAR_READ that pops the name expression's result,
coerces it to string, and pushes the looked-up variable's value
via the shared compiler.LookupVarVar helper. Bit 0 of A is the
"warn on undefined" flag; the emit picks it via
VarVarReadIsWriteParent so the AST runVariableRef's Parent-type
switch is preserved at emit time.

resolveName is extracted onto *runVariableRef so the AST runner
no longer carries the name-resolution code inline.

Write side (LHS of \$\$name = …) still goes through the AST's
runOperator + WriteValue path; only the value-context read is
native here.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

36 of 91 new or added lines in 4 files covered. (39.56%)

15 existing lines in 1 file now uncovered.

14415 of 116889 relevant lines covered (12.33%)

2582.82 hits per line