KarpelesLab / goro / 26065105654

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: propagate error from b.As() in OperatorMathLogic bitwise ops

When the bool/null/int branch coerces operands to int via b.As(),
the conversion can throw (e.g. an installed error_handler turns
the "float INF is not representable as an int" deprecation into
an Exception). The previous code dropped the error with \`_\` and
then dereferenced a nil-Val ZVal, panicking with "interface
conversion: phpv.Val is nil, not phpv.ZInt".

Fixes bitwise_not_precision_exception.phpt; surfaced when CI
exercises bitwise ops with throw-from-warning handlers — the
stack overflow that followed was the test framework recursing
into FuncContext.Release after the panic.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

2 of 11 new or added lines in 1 file covered. (18.18%)

1 existing line in 1 file now uncovered.

14416 of 116897 relevant lines covered (12.33%)

2582.64 hits per line