KarpelesLab / goro / 26064637615

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower runConstant (user / namespaced constant ref) natively

Extracts LookupConstant from runConstant.Run — the case-insensitive
null/true/false/self/parent fast-path, namespace-case-insensitive
global lookup, qualified-name fallback to the global table,
deprecation warnings via checkConstantDeprecated. OP_LOAD_CONSTANT_BY_NAME
pops nothing, pushes the resolved value; the name is stored in the
const-pool (Consts[A]) and the noFallback flag in B's bit 0.

emit_expr.go's constantNode dispatch now picks this opcode instead
of OpClassConst for all non-fast-path constants — PHP_INT_MAX,
user-defined constants, namespaced constants, deprecated constants.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

24 of 39 new or added lines in 4 files covered. (61.54%)

1 existing line in 1 file now uncovered.

14413 of 116829 relevant lines covered (12.34%)

2584.13 hits per line