lsm / neokai / 25967464488

81%

push

github

fix(providers): stop tagging foreign SDK model IDs as anthropic (#1925)

* fix(providers): stop tagging foreign SDK model IDs as anthropic

When ANTHROPIC_BASE_URL is overridden (e.g. user routes Anthropic SDK
traffic to GLM's Anthropic-compatible endpoint, or a previous GLM session
leaked the env var into process.env), the Claude Agent SDK returns foreign
model IDs such as `glm-5`. `AnthropicProvider.convertSdkModels` previously
tagged every returned model as `provider: 'anthropic'`, so GLM models
surfaced in the UI under the Anthropic group.

Filter SDK results to keep only canonical Claude IDs (`sonnet`/`opus`/
`haiku`/`default`/`sonnet[1m]`) and full `claude-*` IDs before conversion.

Also add a defensive FE fallback: when `models.list` omits the `provider`
field on a non-Anthropic ID, `mapRawModelsToModelInfos` now infers the
provider from the family/id instead of blanket-defaulting to `'anthropic'`.

Adds regression tests covering both layers.

* fix(web): align FE provider inference with daemon routing rules

Review feedback on PR #1925 — the family-first FE fallback misclassified
several edge cases:
  - `openai/gpt-*` lumped under anthropic-codex (should be openrouter)
  - `gpt-oss:*` Ollama models lumped under anthropic-codex
  - `kimi-k2:latest` lumped under kimi (colon tag should be Ollama)
  - `claude-*/preview` lumped under openrouter (should stay anthropic)

Reorder inference to prefer ID-based routing (now mirrors the daemon's
`inferProviderForModel` rules) before falling back to the family map,
and tighten `inferProviderFromModelId` accordingly. Add regression tests
for each edge case.

Also drop placeholder URL comment in anthropic-provider.ts and use the
real `MiniMax-M2.5` ID in tests instead of synthetic `minimax-m2`.

* fix(web): route OpenRouter slash refs before colon→ollama fallback

Review feedback on PR #1925 — `google/gemma-4-31b:free` and similar
OpenRouter IDs that carry tier suffixes (`:free`, `:nitro`, etc.) were
caught ... (continued)

8450 of 11719 branches covered (72.11%)

Branch coverage included in aggregate %.

20 of 21 new or added lines in 2 files covered. (95.24%)

65791 of 78842 relevant lines covered (83.45%)

296.62 hits per line