lsm / neokai / 25967340249

81%

push

github

fix: deterministic MCP guard for Space member sessions before query start (#1926)

* fix: deterministic MCP guard for Space member sessions before query start

Space ad-hoc (member) sessions with `context.spaceId` could lose their
`space-agent-tools` MCP server after cache eviction / DB reload, because
runtime-only MCP attachments are tied to the in-memory AgentSession instance.
When the instance is discarded and recreated from DB, the attachments are lost.

This adds a pre-query invariant check (the member-session counterpart to the
existing space_chat invariant) that:

1. Detects when a space-bound member session is missing `space-agent-tools`
   before QueryRunner.start() creates the SDK query.
2. Calls a self-heal callback wired by SpaceRuntimeService when it first
   attaches the tools, which re-runs attachSpaceToolsToMemberSession().
3. Rebuilds query options after self-heal so the SDK sees the repaired map.
4. Throws a hard error if the server is still missing — never silently start
   a degraded Space member turn.

Changes:
- QueryRunner: add `ensureMemberSpaceMcpInvariant()` with self-heal + rebuild
- QueryRunnerContext: add `onMissingMemberSpaceMcpServers` callback
- AgentSession: add `onMissingMemberSpaceMcpServers` property
- SpaceRuntimeService: set the callback in `attachSpaceToolsToMemberSession()`
- Tests: 5 new regression tests covering self-heal, throw, skip conditions

* fix: skip space_task_agent in member MCP invariant + test still-missing throw

Review feedback:
- Add space_task_agent exclusion to ensureMemberSpaceMcpInvariant, matching
  attachSpaceToolsToMemberSession skip logic. Legacy task-agent sessions must
  not hit the member invariant since they intentionally don't receive the
  generic member space-agent-tools server.
- Add test for the defensive "still missing after self-heal" throw path.

8414 of 11678 branches covered (72.05%)

Branch coverage included in aggregate %.

55 of 55 new or added lines in 3 files covered. (100.0%)

65769 of 78821 relevant lines covered (83.44%)

296.56 hits per line