open-quantum-safe / liboqs / 25890987150

82%

Build Type

push

github

Committed by web-flow

Commit Message

Add OQS_SIG_STFL_keygen_and_sign_supported() for runtime detection (#2434)

* Guard trailing_1_bits with OQS_ALLOW_LMS_KEY_AND_SIG_GEN

The static helper trailing_1_bits in hss_keygen.c is only called from
inside the OQS_ALLOW_LMS_KEY_AND_SIG_GEN block, so configurations that
disable stateful key/signature generation (e.g. the
alpine-no-stfl-key-sig-gen CI job) trip -Wunused-function. The warning
was latent until the ci-alpine-amd64 image refresh brought in a CMake
new enough (>= 3.24) for CMAKE_COMPILE_WARNING_AS_ERROR to actually add
-Werror, turning it into a build failure.

Wrap the definition in the same #ifdef as its sole caller.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Re-run clang format due to new CI images

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Stop promoting warnings to errors for upstream XKCP code

xkcp_low/* is imported from the XKCP project and should not be patched
locally. With the refreshed ci-ubuntu-latest container shipping Clang
21.1.8 and a newer CMake, CMAKE_COMPILE_WARNING_AS_ERROR (set via
OQS_STRICT_WARNINGS) is now actually applied — Clang 21 then errors on
-Wimplicit-int-conversion in KeccakP-1600-opt64.c's COMPL macro.

Set COMPILE_WARNING_AS_ERROR=OFF on the four xkcp_low OBJECT targets so
upstream warnings are reported but don't fail the build, insulating us
from future compiler tightening on imported code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Fix more latent warnings exposed by refreshed CI images

In vectors_sig.c, with -DOQS_MINIMAL_BUILD=SIG_slh_dsa the new GCC
treats the ml-dsa-only ext helpers as unused functions and trips on
unused 'extMu' parameters in the verify/sign paths. Guard the
ext helpers with the same ml-dsa #if used at their call sites, mark
extMu as used in the SLH-DSA path, and fix a 'OQS_ENABLE_SLH_DSA'
t... (continued)

Coverage Stats

3 of 10 new or added lines in 2 files covered. (30.0%)

33 existing lines in 10 files now uncovered.

208002 of 252811 relevant lines covered (82.28%)

8207326.79 hits per line