open-quantum-safe / liboqs / 25882818606
82%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2877
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.276% (+0.01%) from 82.266%
25882818606

push

github

web-flow 
Fix latent warnings exposed by refreshed CI container images (#2430)

* Guard trailing_1_bits with OQS_ALLOW_LMS_KEY_AND_SIG_GEN

The static helper trailing_1_bits in hss_keygen.c is only called from
inside the OQS_ALLOW_LMS_KEY_AND_SIG_GEN block, so configurations that
disable stateful key/signature generation (e.g. the
alpine-no-stfl-key-sig-gen CI job) trip -Wunused-function. The warning
was latent until the ci-alpine-amd64 image refresh brought in a CMake
new enough (>= 3.24) for CMAKE_COMPILE_WARNING_AS_ERROR to actually add
-Werror, turning it into a build failure.

Wrap the definition in the same #ifdef as its sole caller.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Re-run clang format due to new CI images

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Stop promoting warnings to errors for upstream XKCP code

xkcp_low/* is imported from the XKCP project and should not be patched
locally. With the refreshed ci-ubuntu-latest container shipping Clang
21.1.8 and a newer CMake, CMAKE_COMPILE_WARNING_AS_ERROR (set via
OQS_STRICT_WARNINGS) is now actually applied — Clang 21 then errors on
-Wimplicit-int-conversion in KeccakP-1600-opt64.c's COMPL macro.

Set COMPILE_WARNING_AS_ERROR=OFF on the four xkcp_low OBJECT targets so
upstream warnings are reported but don't fail the build, insulating us
from future compiler tightening on imported code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Fix more latent warnings exposed by refreshed CI images

In vectors_sig.c, with -DOQS_MINIMAL_BUILD=SIG_slh_dsa the new GCC
treats the ml-dsa-only ext helpers as unused functions and trips on
unused 'extMu' parameters in the verify/sign paths. Guard the
ext helpers with the same ml-dsa #if used at their call sites, mark
extMu as used in the SLH-DSA path, and fix a 'OQS_ENABLE_SLH_DSA'
typo th... (continued)

207994 of 252801 relevant lines covered (82.28%)

8200200.23 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
96.72
 -3.28% src/kem/classic_mceliece/pqclean_mceliece460896f_clean/encrypt.c
2
61.9
 -0.45% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/sign.c
1
96.08
 -1.96% src/kem/classic_mceliece/pqclean_mceliece348864_avx2/encrypt.c
1
96.72
 -1.64% src/kem/classic_mceliece/pqclean_mceliece348864_clean/encrypt.c
1
96.72
 -1.64% src/kem/classic_mceliece/pqclean_mceliece348864f_clean/encrypt.c
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/rounding.h
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/rounding.h
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-87_aarch64/mldsa/src/rounding.h
1
94.44
 -1.85% src/sig/uov/pqov_ov_Is_pkc_ref/ov.c
1
93.55
 -1.61% src/sig/uov/pqov_ov_Is_pkc_skc_ref/ov.c
Jobs
ID Job ID Ran Files Coverage
1 x64-distbuild - 25882818606.1 2346
56.5
 GitHub Action Run
2 x64-generic - 25882818606.2 1259
85.38
 GitHub Action Run
3 arm64-distbuild - 25882818606.3 1789
60.32
 GitHub Action Run
Source Files on build 25882818606