KarpelesLab / goro / 25815383922

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: AST-delegate NoDiscard-wrapped statements

The AST wraps a statement-context call to a #[NoDiscard]-annotated
function/method in runNoDiscardStatement so its Run() emits the
"return value should either be used or intentionally ignored"
warning when the call's result is discarded. The VM was unwrapping
the NoDiscard layer at emit time, silently dropping the warning.

Now AST-delegate the whole statement via OpTryFinally + refresh
slots, and mark IsSlotSafe=false so the AST reads operands from
the hashtable.

Fixes attributes/nodiscard/005 (DateTimeImmutable::setTimestamp
discarded result).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

30 existing lines in 7 files now uncovered.

13934 of 115732 relevant lines covered (12.04%)

2452.82 hits per line