IJHack / QtPass / 25790576572

55%

push

github

fix: rename internal drag-drop MIME type to RFC 6838 form (#1468)

* fix: rename internal drag-drop MIME type to RFC 6838 form

The internal MIME identifier QtPass uses for drag-and-drop payloads
was registered as "application/vnd+qtpass.dragAndDropInfoPasswordStore".
The '+' in that form is reserved for structured-syntax suffixes (e.g.
"application/atom+xml") in RFC 6838; the vendor-tree separator is
'.'. Rename to "application/vnd.qtpass.dragAndDropInfoPasswordStore".

Used in exactly 9 places, all inside QtPass:
- src/storemodel.cpp: mimeTypes(), mimeData(), canDropMimeData() x2,
  parseDropData()
- tests/auto/model/tst_storemodel.cpp: 4 assertions + makeMimeData()

Internal-only identifier (drag/drop happens between QtPass widgets in
the same process), so no compatibility break.

Also rearrange the test include block — <memory> now sits with the
C++ stdlib headers above the Qt headers, matching the
stdlib-then-Qt-then-project convention used elsewhere.

Build clean, 33/33 storemodel tests pass.

Other CodeRabbit nits in tst_util.cpp (DF9 underscore, hoist
ASSUMED_MAX_KEY_ID_LENGTH, ScopedUmask RAII) were re-evaluated and
still skipped — same rationale as #1467.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test: QVERIFY2 on the two MIME-type assertions

CodeRabbit nit on #1468 follow-up: bare QVERIFY() on the
mimeTypes()/mimeData() assertions doesn't say which MIME string was
expected if the test fails. Switch to QVERIFY2 with descriptive
messages.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

1948 of 6720 relevant lines covered (28.99%)

27.12 hits per line