25764176232
55%

Ran 12 May 2026 09:53PM UTC

Jobs 1

Files 72

Run time 1min

Badge

Embed ▾

Committed 12 May 2026 09:47PM UTC coverage: 28.988%. Remained the same

Build # 25764176232

Build Type

push

github

Committed by

web-flow

Commit Message

test: bump tests/tests.pri to c++17, drop legacy make_unique workaround (#1467)

CodeRabbit flagged the comment in tst_storemodel.cpp claiming
"make_unique is c++14, tests are pinned to c++11" as outdated. On
investigation:

- src/src.pro already requires c++17 (project enforces it per
  CLAUDE.md and uses std::as_const broadly), so any test that
  #includes a src/ header transitively needs the same standard.
- The compile commands produced by qmake for tests don't actually
  contain a -std= flag — gcc 13+ defaults to c++17 anyway, which is
  why clang-tidy's modernize-make-unique was firing on this very
  workaround.

Two changes:

- tests/tests.pri: c++11 → c++17, matching src/src.pro and reality.
- tst_storemodel.cpp: replace the std::unique_ptr<T>(new T) /
  three-line comment dance with a plain std::make_unique<QMimeData>().

No semantic change. 33/33 model tests + 120/120 util tests still pass.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

1948 of 6720 relevant lines covered (28.99%)

27.12 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	25764176232.1	12 May 2026 09:53PM UTC	72	28.99	GitHub Action Run

IJHack / QtPass / 25764176232
55%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 25764176232

IJHack / QtPass / 25764176232 55%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 25764176232

IJHack / QtPass / 25764176232
55%

README BADGES
x