zalando / skipper / 25787555574

80%

Build Type

push

github

Committed by web-flow

Commit Message

fix: create an access log instance instead of pkg global (#3998)

fix: create an access log instance instead of pkg global

Library users that would use logging.LogAccess will need to use
logging.NewLogAccess() and use inst.LogAccess()
I think this won't be widely in use, because skipper.Run() will do it
automatically.

Migration for skipper as library users in case you initialize the logger
yourself (very unlikely the case as we automatically do this in a not
exported func), replace:
```
logging.Init(logging.Options{
...
skipper.Options{
...
}
```
by
```
lg := logging.NewAccessLogger(logging.Options{
...

skipper.Options{
...
    AccessLogger: accessLogger,
...
```

---------

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

Coverage Stats

27 of 29 new or added lines in 4 files covered. (93.1%)

9 existing lines in 4 files now uncovered.

27018 of 33798 relevant lines covered (79.94%)

86322.68 hits per line