zalando / skipper

80%

Build Type

push

github

Committed by web-flow

Commit Message

Move nil EndpointSlice conditions in isReady (#4136)

Move nil EndpointSlice conditions handling into
`EndpointSliceEndpoints.isReady()`.


EndpointSlice endpoints with missing conditions is already treated as
ready. So instead of having this check outside isReady moved it within.

This makes the `isReady` function handle all cases and avoids requiring
future callers to duplicate the nil-condition check.

## Tests

```bash
go test ./dataclients/kubernetes -run TestEndpointSliceEndpointIsReady
go test ./dataclients/kubernetes
```

Suggested label: refactor or bugfix (actually not a bug)


Fixes https://github.com/zalando/skipper/issues/4137

Signed-off-by: shrikant23codes <jiturishrikant@gmail.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

28866 of 35893 relevant lines covered (80.42%)

80417.35 hits per line