zalando / skipper / 25736716608

80%

Build Type

push

github

Committed by web-flow

Commit Message

Async decision logging for OPA (#4001)

Adds an opt-in async decision logging mode
(--enable-open-policy-agent-async-decision-logging) that offloads
decision log calls to a background goroutine, preventing slow log
plugins (e.g. eopa_dl writing to S3) from adding latency to HTTP
responses.

When enabled, each OPA instance maintains a bounded channel. logDecision
does a non-blocking send into it; if the buffer is full the event is
dropped with a warning rather than blocking the request goroutine. A
dedicated runDecisionLogger goroutine drains the channel and performs
the actual log call. On shutdown, Close drains the channel to completion
before stopping the manager, respecting the context deadline.

The channel buffer size is derived from
decision_logs.reporting.buffer_size_limit_events in the OPA config
template, keeping it consistent with OPA's own buffer configuration. If
not set, it defaults to 1000.


Signed-off-by: nuwandi-wickramasinghe_zse <nuwandi.wickramasinghe@zalando.de>

Coverage Stats

8 of 50 new or added lines in 4 files covered. (16.0%)

3 existing lines in 2 files now uncovered.

27019 of 33792 relevant lines covered (79.96%)

86494.07 hits per line