lsm / neokai / 25686166199

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(daemon): normalize Space runtime notifications via InternalEventBus (M6) (#1860)

* feat(daemon): normalize Space runtime notifications via InternalEventBus (M6)

Define Space runtime domain events as typed channels with dot-separated
camelCase names (space.task.blocked, space.workflowRun.completed, etc.)
and publish them through InternalEventBus on all Space runtime state transitions.

- Add SpaceEvents interface to internal-event-bus.ts with 16 event types
  covering task, agent, and workflowRun lifecycle events.
- Add SpaceEvents to DaemonInternalEventMap intersection.
- Wire SpaceRuntime.safeNotify() to dual-publish: legacy NotificationSink
  path plus new InternalEventBus path via mapNotificationEventToInternalEvent().
- Add internalEventBus field to SpaceRuntimeConfig.
- Implement SpaceAgentNotificationService as an InternalEventBus subscriber
  that turns selected Space events into agent-facing [TASK_EVENT] messages.
- Mark NotificationSink, NullNotificationSink, setNotificationSink(), and
  getNotificationSink() as @deprecated with M6 removal plan.
- Add tests for SpaceAgentNotificationService (23 tests) and dual-publishing
  integration in space-runtime-notifications.test.ts.

The legacy NotificationSink path remains functional for backward compatibility;
all existing tests continue to pass.

* fix(daemon): address M6 review feedback on production wiring and types

- Wire internalEventBus through SpaceRuntimeService → SpaceRuntime
- Instantiate SpaceAgentNotificationService per-space in setupSpaceAgentSession
- Pass internalEventBus to ChannelRouter for workflow_run_reopened dual-publish
- Add type-safe publishToInternalEventBus helper to avoid unsafe casts
- Extract shared SessionFactory interface to runtime/types.ts
- Document 4 reserved but unemitted event types in DaemonInternalEventMap
- Add barrel exports for SpaceAgentNotificationService and SessionFactory
- Update tests for service-level autonomy in task_awaiting_approval

* feat... (continued)

Coverage Stats

8347 of 11648 branches covered (71.66%)

Branch coverage included in aggregate %.

564 of 609 new or added lines in 6 files covered. (92.61%)

2 existing lines in 1 file now uncovered.

66613 of 79113 relevant lines covered (84.2%)

289.68 hits per line