lsm / neokai / 25672010875

82%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: split StateManager into StateProjectionService + InternalEventBus subscribers (M5) (#1858)

* refactor: split StateManager into StateProjectionService + InternalEventBus subscribers (M5)

- Rename StateManager → StateProjectionService in new file; old file is a
  compatibility re-export (StateManager alias) for downstream imports.
- Route all state-cache updates through InternalEventBus subscriptions instead
  of direct DaemonHub listeners:
  • session.created, session.updated, session.deleted
  • commands.updated, session.error, session.errorClear
  • api.connection, settings.updated
- Add DaemonInternalEventMap entries for SessionEvents and ApiConnectionEvents.
- Bridge migrated DaemonHub events to InternalEventBus in app.ts so existing
  publishers continue to work without touching every call site.
- Client delivery remains fully routed through ClientEventBridge (M4).
- Side effects (broadcastSystemChange, broadcastSettingsChange,
  broadcastSessionStateChange) are triggered by InternalEventBus subscribers
  inside StateProjectionService, keeping them separate from cache updates.
- Update client-event-bridge docs to reference StateProjectionService.
- Add knip ignore for the compatibility re-export file.
- All 9824 daemon unit tests pass; lint + typecheck + knip pass.

* fix: address review feedback on M5 bridge (complete payload, sync ordering, shim compat)

- Forward complete api.connection payload via spread (...data) so diagnostic
  fields (errorCount, lastError, lastSuccessfulCall) are preserved.
- Switch DaemonHub→InternalEventBus bridge from publishAsync to publish()
  so cache updates settle synchronously before ClientEventBridge triggers
  broadcastSystemChange(), preserving ordering between cache write and
  broadcast read.
- Add StateProjectionService.createLegacy() static factory that accepts the
  old StateManager constructor signature (including daemonHub as 6th arg)
  and forwards to the new constructor. Update compatibilit... (continued)

Coverage Stats

8346 of 11648 branches covered (71.65%)

Branch coverage included in aggregate %.

360 of 395 new or added lines in 2 files covered. (91.14%)

3 existing lines in 3 files now uncovered.

66036 of 78513 relevant lines covered (84.11%)

290.19 hits per line