lsm / neokai / 25632447293

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: extract room and space event forwarding into ClientEventBridge (#1835)

* refactor: extract room and space event forwarding into ClientEventBridge

Move ~30 repetitive daemon-to-client forwarding handlers from StateManager
into a new declarative ClientEventBridge module.

- New `packages/daemon/src/lib/client-event-bridge.ts` with ROOM_BRIDGE_MAPPINGS
  and SPACE_BRIDGE_MAPPINGS registries. Each mapping declares the DaemonHub
  event, client event name, target EventChannel, and optional transform.
- StateManager loses the room.*, goal.*, space.*, spaceAgent.*, and
  spaceWorkflow.* forwarding blocks; gains `getClientEventGateway()` as a
  temporary seam.
- DaemonApp wires the bridge after StateManager construction.
- Comprehensive unit tests for the bridge (subscription, idempotency, stop,
  and per-event forwarding assertions with correct EventChannel shapes).
- StateManager tests updated to assert the forwarding handlers are no longer
  registered there.

Scope: pure forwarding only — no state caching, no version increments, no
side effects. Remaining handlers (session.*, api.connection, auth.changed,
etc.) stay in StateManager for follow-up PRs.

* test: address review feedback on state-manager.test.ts

- P1: Restore the "falls back to a default ClientEventGateway" test so it
  actually builds a StateManager without injecting a gateway, and asserts
  the returned gateway has publish/publishGlobal methods.
- P2: Flatten duplicate nested describe('ClientEventGateway DI seam') blocks.
- P3: Add goal.updated negative assertion to the "should NOT register
  room/space forwarding handlers" test, and remove stale spaceSessionGroup.*
  assertions that no longer apply.

* refactor: remove dead room/goal bridge mappings

Room and goals have been removed from the codebase — there are zero
emitters for room.* and goal.* events. The 6 ROOM_BRIDGE_MAPPINGS entries
were dead code forwarding events nobody emits.

- Remove ROOM_BRIDGE_MAPPINGS and the roo... (continued)

Coverage Stats

8240 of 11521 branches covered (71.52%)

Branch coverage included in aggregate %.

118 of 118 new or added lines in 3 files covered. (100.0%)

1168 existing lines in 14 files now uncovered.

65057 of 77420 relevant lines covered (84.03%)

289.32 hits per line