lsm / neokai / 25624089872

82%

push

github

refactor: simplify external event architecture — remove task coupling (#1833)

* feat: implement ExternalEventService and ExternalEventTaskResolver

- Add ExternalEventService implementing ExternalEventPublisher
  - publish() returns published, duplicate_terminal, retryable_duplicate, or ignored
  - Validates source/topic contracts via ExternalEventStore
  - Stores/dedupes via ExternalEventStore
  - Enriches events through ExternalEventTaskResolver
  - Publishes externalEvent.published on InternalEventBus with space-scoped payload
- Add ExternalEventTaskResolver interface + GitHubExternalEventTaskResolver
  - Resolves GitHub PR events to SpaceTasks via trusted metadata or heuristic
  - Explicit ambiguous/unknown/ignored/enriched result types
  - No direct workflow/task/gate table queries
- Add markEventAmbiguous() to ExternalEventStore for terminal ambiguous transitions
- Extend DaemonInternalEventMap with ExternalEventEvents
- Add unit tests covering new event, terminal duplicate, retryable duplicate,
  enriched routedTaskId, ambiguous/unknown task resolution, and bus semantics

* fix: address PR review feedback for ExternalEventService and task resolver

- Persist routedTaskId via ExternalEventStore.setRoutedTaskId() before
  advancing state to routed (was never written to DB).
- Retryable duplicates now re-emit the bus event so failed subscribers
  get another chance; include routedTaskId in retryable result.
- Ignored resolver results no longer mark terminal — leave event in
  published so a later re-observation with complete metadata can enrich.
- Add word-boundary regex for PR number matching (#42 no longer matches
  inside #420 or abc#42x).
- Add optional taskRepoFilter to GitHubTaskResolverConfig for repo-scoped
  narrowing in multi-repo spaces.
- Expand tests: boundary matching, repo filter, markEventAmbiguous,
  setRoutedTaskId, non-terminal ignored, bus re-emit on retryable dup.

* fix: address round-2 review feedback for ExternalEventServi... (continued)

8232 of 11438 branches covered (71.97%)

Branch coverage included in aggregate %.

100 of 101 new or added lines in 4 files covered. (99.01%)

64271 of 76231 relevant lines covered (84.31%)

290.51 hits per line