bitcoindevkit / bdk / 25599826179

79%

master: 78%

push

github

Merge bitcoindevkit/bdk#2197: fix(electrum): backport PR#2195

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/4d862fdad3aa63b5e2027216c68dda84595abdad">4d862fdad fix(electrum): do not pick unindexed outputs for history lookup (Zoe Faltibà)

Pull request description:

  ### Description

  it's basically a backport into `chain/0.23.x` for the fix for bdk_electrum introduced by #2195.

  ### Notes to the reviewers

  check the original PR for the original description/rationale.

  ### Changelog notice

  ```
  ### Fixed:
  - `BdkElectrumClient::sync` now correctly retrieves confirmation status for transactions which first output is an `OP_RETURN` or `OP_FALSE OP_RETURN`
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  luisschwab:
    ACK 4d862fdad3aa63b5e2027216c68dda84595abdad
  evanlinjin:
    ACK 4d862fdad3aa63b5e2027216c68dda84595abdad

Tree-SHA512: f466d5fa898c408f321be733cb35f4bf495

386 of 532 branches covered (72.56%)

Branch coverage included in aggregate %.

0 of 23 new or added lines in 1 file covered. (0.0%)

4401 of 5527 relevant lines covered (79.63%)

2058.72 hits per line