karellen / karellen-jdtls-kotlin / 25456954821

80%

Build Type

push

github

Committed by web-flow

Commit Message

Support camelcase and pattern matching in locateMatches (#32)

## Summary

- `matchesTypeName()`, `matchesTypeAliasName()`, and
`locateFacadeTypeMatch()` now use `TypeDeclarationPattern.matchesName()`
instead of `equalsIgnoreCase`, supporting all JDT match rules (exact,
prefix, camelcase, wildcard)
- Adds `WorkspaceSymbolSearchTest` (8 tests) validating workspace/symbol
search for Kotlin types

## Motivation

Workspace/symbol queries (`workspace/symbol` LSP method) use
`R_CAMELCASE_MATCH` and `R_PATTERN_MATCH`. The index correctly selected
documents containing matching Kotlin types, but `locateMatches()`
rejected all declarations because the name comparison used
`equalsIgnoreCase` — only exact matches passed.

`TypeDeclarationPattern.matchesName()` is the same method JDT Core uses
in `matchesDecodedKey()` during index queries. It respects the pattern's
match rule, handling camelcase (e.g., "IPS" →
`InventoryPopulationService`), wildcards (e.g., `*Population*`), prefix,
and exact matching.

Companion fix:
[eclipse.jdt.ls#3732](https://github.com/eclipse-jdtls/eclipse.jdt.ls/pull/3732)
supplements `WorkspaceSymbolHandler.searchAllTypeNames()` with a
`search()` call through contributed participants, since
`searchAllTypeNames` only queries the default Java participant's
indexes.

## Test plan

- [x] `testSearchAllTypeNamesDoesNotFindKotlinTypes` — confirms
`searchAllTypeNames` gap
- [x] `testSearchAllTypeNamesCamelCaseDoesNotFindKotlinTypes` — confirms
camelcase gap
- [x] `testSearchWithParticipantsFindsKotlinTypeExact` — exact match via
`search()`
- [x] `testSearchWithParticipantsFindsKotlinTypeCamelCase` — "IPS" finds
`InventoryPopulationService`
- [x] `testSearchWithParticipantsFindsKotlinTypePatternMatch` —
`*Population*` finds type
- [x] `testSearchWithParticipantsFindsMultipleKotlinTypes` —
`Inventory*Service` finds 2 types
- [x] `testSearchWithParticipantsFindsKotlinInterface` — "IR" finds
interface + implementation
- [x] `testSearchWithParticipant... (continued)

Coverage Stats

2490 of 3555 branches covered (70.04%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

86 existing lines in 1 file now uncovered.

5231 of 6137 relevant lines covered (85.24%)

3.01 hits per line