wboayue / rust-ibapi / 25288050972

92%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(orders/test): apply /simplify cleanup (#498)

Follow-up to #497. Address review findings:

- Inline trivial `double_str` rename to `v.to_string()` (13 sites).
- Replace inline `opt_str` closure with existing `proto::encoders::some_str`.
- Add top-of-file `use proto::encoders::{..}` to drop 8 qualified prefixes —
  matches `positions.rs` convention.
- Change `PlaceOrderRequestBuilder::{contract,order}` and
  `ExerciseOptionsRequestBuilder::contract` setters to take references; drops
  `.clone()` noise at 6 test call sites.
- Drop 8 narration comments (`// Test X response`, `// First event:`).
- Extract 7 OpenOrder/CompletedOrder pipe-delimited literals (10 occurrences)
  to `src/orders/common/test_data.rs` so sync/async tests share fixtures.

Net -41 lines. clippy clean on default/sync/all-features; all tests pass.

Coverage Stats

26 of 31 new or added lines in 1 file covered. (83.87%)

1 existing line in 1 file now uncovered.

18015 of 20446 relevant lines covered (88.11%)

24.12 hits per line