wboayue / rust-ibapi / 25289727697

92%

Build Type

push

github

Committed by web-flow

Commit Message

test(contracts): builders + body-verifying test migration (#499)

* test(contracts): builders + body-verifying test migration

Mirrors the accounts/orders test-builder PRs. Adds typed request
builders for every contracts encoder (contract_data, matching_symbols,
market_rule, calculate_option_price/implied_volatility, the three
cancels, option_chain) plus sentinel response builders for
ContractDataEnd and OptionChainEnd. Migrates sync/async tests to
assert_request<B> for body verification, and drops the encoder
self-loop tests now redundant with the migrated paths. Adds a
test_cancel_contract_details case (no prior unit-test coverage).

ContractData / SymbolSamples / MarketRule / OptionChain response
bodies deferred -- same rationale as PR 3 OpenOrder/CompletedOrder.

OptionChainEnd needs a custom builder (request_id at index 1, no
version field), unlike the other End sentinels.

* test(contracts): drop unused builders surfaced by review

Per /review feedback on PR 4: the response sentinel builders
(ContractDataEnd, OptionChainEnd) and two unused cancel builders
(CancelOptionPrice, CancelImpliedVolatility) had no production-path
consumer -- they only fed their own wire-format unit tests, which is
exactly the self-loop pattern PR 3 lessons say to avoid.

Drop them. The deferred-builder note moves to the file header.
contracts_tests.rs deleted (the two tests it held only validated the
now-removed builders).

cancel_contract_data builder kept -- it is consumed by the new
test_cancel_contract_details path.

* refactor(contracts/test): apply /simplify cleanup

- Drop magic 26 default in MarketRuleRequestBuilder; every caller
  already overrides via .market_rule_id(test_case.market_rule_id),
  so default to 0 and derive Default.
- Trim builders/contracts.rs header to drop PR-relative reference
  (will rot post-merge); keep the durable rule.
- Trim the 8-line "intentionally omitted" block in encoders.rs to 3
  lines pointing at where coverage actually lives.
... (continued)

Coverage Stats

174 of 174 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

18096 of 20518 relevant lines covered (88.2%)

24.17 hits per line