wboayue / rust-ibapi / 25257614989
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 114
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.836%. Remained the same
25257614989

push

github

web-flow 
test(connection): port unique tests, close parity gaps (PR 4/5) (#479)

* test(connection): port unique tests, close parity gaps (PR 4/5)

Per todos/eliminate-mock-gateway.md PR 4 and the audit table.

Migrate to connection/sync_tests.rs and connection/async_tests.rs
(MemoryStream + Connection::stubbed / AsyncConnection::stubbed):
- establish_connection_populates_metadata
- disconnect_completes / disconnect_completes_after_eof
- disconnect_is_idempotent

Parity-fix:
- orders/sync/tests.rs:exercise_options (mirrors async)
- market_data/realtime/async/tests.rs:subscription_cancel_only_sends_once
  (mirrors sync, issue #258)

Unblocks PR 5: deleting client/sync/tests.rs, client/async/tests.rs, and
MockGateway infrastructure.

* test(connection): apply review feedback

- Sync disconnect tests now push the -2 IncomingMessages::Shutdown
  sentinel instead of EOF, mirroring TWS's clean-shutdown protocol.
  Avoids exercising the 20-iteration reconnect-retry loop incidentally.
  Renamed disconnect_completes_after_eof -> disconnect_completes.
- Async make_client clones the MemoryStream up front instead of
  reaching into connection.socket via a helper. Mirrors sync.
- Drop the redundant compile-only scaffold tests now that
  establish_connection_populates_metadata exercises the same wiring.

* test(connection): simplify per CLAUDE.md comment guidance

- Drop file-level and per-test doc comments that narrate WHAT or
  reference task context (PR 4, "Migrated from", issue #258).
- Replace magic msg ids 9 and 15 with IncomingMessages::NextValidId /
  ManagedAccounts (matches sync_tests.rs's existing use of
  IncomingMessages::Shutdown).
- Tighten time_zone assertion to compare against timezones::db::EST
  rather than just asserting Some.

17952 of 19983 relevant lines covered (89.84%)

40.3 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25257614989.1 114
89.84
 GitHub Action Run
Source Files on build 25257614989