wboayue / rust-ibapi / 25258750129

92%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(test): remove MockGateway, collapse client/{sync,async} (PR 5/5) (#480)

Per todos/eliminate-mock-gateway.md PR 5 and the audit table.

Deletions (~6,400 LOC):
- client/sync/tests.rs (2,555 LOC, MockGateway-driven)
- client/async/tests.rs (2,527 LOC, MockGateway-driven)
- client/test_support/{mocks,scenarios,mod}.rs (~1,300 LOC)

Migrations:
- client/builders/{sync,async}.rs MockGateway test blocks now use
  Client::stubbed + MessageBusStub::default(). The fixtures only ever
  needed a Client instance, not a real gateway.

Layout:
- client/sync/{mod.rs,tests.rs} -> client/sync.rs (flat sibling, per
  CLAUDE.md item 13: a directory module that exists only to host
  tests.rs collapses to flat).
- client/async/{mod.rs,tests.rs} -> client/async.rs (same).
- client/mod.rs drops `mod test_support;`.

Coverage parity preserved:
- 109 of 117 deleted tests were duplicates of per-domain MessageBusStub
  tests (verified in todos/eliminate-mock-gateway-audit.md).
- 6 unique tests (handshake x2, disconnect x4) migrated in PR 4 to
  connection/{sync,async}_tests.rs via MemoryStream.
- 3 parity gaps closed in PR 4.

Coverage Stats

45 of 45 new or added lines in 2 files covered. (100.0%)

326 existing lines in 18 files now uncovered.

16871 of 19263 relevant lines covered (87.58%)

25.46 hits per line