lsm / neokai / 25232795924

82%

push

github

Graceful socket disconnection handling in UI (#1748)

* Graceful socket disconnection handling in UI

Replace full-page blocking error overlay with non-blocking inline banner
that shows connection state progression: Reconnecting → Connection lost →
Unable to reconnect. Queue outbound messages during disconnection and flush
on reconnect. Sanitize internal error messages before surfacing to users.
Detect auth/session expiry and redirect instead of retrying.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Address review feedback: deliveryMode, 403, transport cleanup, test alignment

- Include deliveryMode in queued message closure (P1)
- Remove 403 from isAuthError — it's permission denied, not session expiry (P1)
- Stop transport and auto-flush before auth redirect to prevent reconnect loop (P1)
- Export getBannerLevel from ConnectionOverlay and test the real function (P2)
- Reorder handleDisconnect before setState in forceReconnect for correct attempt count (P2)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix: queue message when hub disappears mid-send, guard flush against disconnect

Three fixes from PR review feedback:
- Hub-null path now enqueues message instead of showing misleading toast
- Offline queue path now calls onMessageAccepted with the server response
- flushQueue() guards against disconnection: skips when disconnected,
  breaks mid-flush if connection drops, leaving remaining actions pending

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix: use consistent em dash in "Message queued" toast strings

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix: prevent unhandled rejection in hub-null enqueue, fix reconnect banner flicker

Two fixes:
- Hub-null path passes { executeImmediately: false } to enqueueAction,
  preventing immediate-execution rejection since connectionState is still
  'connected' but the hub is gone
- getBannerLevel only hides 'connecting' on initial load (attempts=0);
 ... (continued)

7804 of 10203 branches covered (76.49%)

Branch coverage included in aggregate %.

107 of 155 new or added lines in 7 files covered. (69.03%)

60503 of 84556 relevant lines covered (71.55%)

253.94 hits per line