decentraland / comms-gatekeeper / 25228902518

85%

main: 85%

Pull #261

github

fix: release cooldown on webhook-refresh failure; align admin auth status

addresses two reviewer comments:

- updateRoomMetadataForRoom now removes the cooldown cache key from the
  catch block. previously a transient place-lookup blip would consume
  the full 60s slot and block the next webhook from reconciling. on
  success the cooldown still stays — that's what protects against the
  thundering herd. on persistent failure the cost is a retry per
  webhook, which is the correct signal that something upstream is down.
  refreshRoomMetadata catches its own errors so reaching the outer
  catch block here is a real lookup failure.
- addSceneAdminHandler now throws UnauthorizedError (→ 401) instead of
  InvalidRequestError (→ 400) when verification.auth is missing.
  matches the http convention and removeSceneAdminHandler.

new test: place-lookup fails once then succeeds → expects two place
lookups and one metadata write, asserting the cooldown was released
between the two webhook calls.

1061 of 1369 branches covered (77.5%)

Branch coverage included in aggregate %.

170 of 177 new or added lines in 15 files covered. (96.05%)

2994 of 3387 relevant lines covered (88.4%)

75.1 hits per line