decentraland / comms-gatekeeper / 25227524513

85%

main: 85%

Pull #261

github

refactor: fold land-lease into the lands wkc component

land-lease was a tiny adapter that only the lands-related logic ever
consumed: scene-manager (hasLandLease), the list-scene-admins handler
(getAuthorizations), and roomMetadataSync (lease-holders lookup, via the
intermediate getLeaseHoldersForParcels in lands). consolidating the two
collapses the cross-adapter dep introduced by the previous commit, gives
us one component that owns "everything land-related" (on-chain operators,
parcel permissions, off-chain lease authorizations), and removes a
top-level component from BaseComponents.

the lease internals (5-min cache, single in-flight fetch dedup,
serve-stale on transient failure, hasLandLease / getAuthorizations /
refreshAuthorizations) are preserved verbatim. types and the
LandLeaseAuthorization shape moved into src/adapters/lands/types.ts.

scene-manager now uses lands.hasLandLease; the list-scene-admins handler
already moved to lands.getLeaseHoldersForParcels; roomMetadataSync's
lands dep is unchanged. createLandsComponent now takes `fetch` (for the
authorizations http call) and no longer takes `landLease`. components.ts
drops landLease creation and removes it from the returned components map.

test moves:
- test/unit/land-lease.spec.ts → test/unit/lands-lease.spec.ts (same
  21 tests, factored through a small helper that supplies inert
  config/cachedFetch defaults so the lease tests stay focused)
- the getLeaseHoldersForParcels tests moved out of the integration
  land-component spec and into lands-lease.spec.ts where the lease
  fixtures already live; they now mock fetch directly
- scene-manager-component.spec.ts and list-scene-admins-handler.spec.ts
  now stub stubComponents.lands.hasLandLease / .getAuthorizations
  instead of stubComponents.landLease.*

1061 of 1369 branches covered (77.5%)

Branch coverage included in aggregate %.

169 of 175 new or added lines in 15 files covered. (96.57%)

2993 of 3386 relevant lines covered (88.39%)

75.25 hits per line