decentraland / comms-gatekeeper / 25226858307

85%

main: 85%

Build Type

Pull #261

github

Committed by LautaroPetaccio

Commit Message

refactor: lands adapter as a wkc component, owns lease-holders lookup

splits src/adapters/lands.ts into the standard wkc layout under
src/adapters/lands/ (component.ts, types.ts, errors.ts, index.ts) and
moves LandPermissionsNotFoundError + the Lands*Response types into the
component folder where they belong.

adds `lands.getLeaseHoldersForParcels(parcels)` so the lease-overlap
filter has one canonical home. previously the same loop was inlined in
both list-scene-admins-handler.ts and roomMetadataSync.refreshRoomMetadata
— small but real duplication. the new method:

- delegates to landLease.getAuthorizations() and filters by parcel
  overlap, lowercasing addresses on the way out.
- catches errors locally and returns [] so callers (notably the
  Promise.all in refreshRoomMetadata) don't have one flaky source
  drop bans/admins from the metadata write.

both consumers now call lands.getLeaseHoldersForParcels(place.positions)
guarded by `place.world` so the world skip lives at the call site
where the place metadata is available.

Pull Request Pull Request #261: refactor: extract room metadata sync and add scene admins to metadata

Coverage Stats

1061 of 1365 branches covered (77.73%)

Branch coverage included in aggregate %.

100 of 101 new or added lines in 14 files covered. (99.01%)

1 existing line in 1 file now uncovered.

3002 of 3394 relevant lines covered (88.45%)

75.12 hits per line