decentraland / comms-gatekeeper / 25225789460

85%

main: 85%

Build Type

Pull #261

github

Committed by LautaroPetaccio

Commit Message

refactor: tighten sceneId typing and guard scene-room parsing

addresses two type-safety review comments:

- GetRoomNameParams.sceneId is now `sceneId?: string`, matching the
  runtime: getRoomName already handles a missing sceneId (legacy world
  fallback for `isWorld: true`, throw for non-world). callers no longer
  need `undefined as unknown as string` casts in tests.
- updateRoomMetadataForRoom drops the `sceneId!` non-null assertion in
  the non-world branch and adds an explicit guard: if a scene room name
  parses without a sceneId, log a warning and skip rather than letting
  contentClient.fetchEntityById blow up on `undefined`. defensive but
  cheap, and surfaces malformed room names as a single warn line.

Pull Request Pull Request #261: refactor: extract room metadata sync and add scene admins to metadata

Coverage Stats

1063 of 1364 branches covered (77.93%)

Branch coverage included in aggregate %.

85 of 86 new or added lines in 9 files covered. (98.84%)

7 existing lines in 3 files now uncovered.

3002 of 3394 relevant lines covered (88.45%)

43.28 hits per line