dangernoodle-io / TaipanMiner / 25204685441

90%

push

github

feat(fan): autofan PID with temp setpoint, replacing fixed curve (#290)

* feat(fan): autofan PID with temp setpoint, replacing fixed curve

Replace the open-loop temp→duty curve (`emc2101_curve.h`) with a
closed-loop PID controller that drives fan duty toward a configurable
temperature setpoint, matching AxeOS behavior. Vendor a small
host-testable PID (Brett Beauregard's algorithm, MIT) with the time
source abstracted via a function pointer so unit tests inject a mock
clock and the ESP target injects esp_timer.

- new components/asic/{include/pid.h,src/pid.c}: PIDController API,
  modes (AUTOMATIC/MANUAL), proportional-on-error/measurement, output
  clamping, sample-time gating, output-limits-aware integral wind-up
  protection
- taipan_config exposes four NVS-backed knobs: autofan_enabled (default
  true), temp_target_c (default 60, clamped 35..85), manual_fan_pct
  (default 100), min_fan_pct (default 25)
- asic_task fan tick (5s cadence) selects between overheat fail-safe,
  autofan PID, and manual fixed pct; EMA-filters the diode reading
  (alpha=0.2) before feeding the PID; refreshes setpoint and min from
  config each tick so they're live-tunable
- /api/fan GET extends the existing snapshot with autofan/target/manual/
  min; new POST handler accepts form-urlencoded partial updates and
  persists via taipan_config setters
- delete the fixed curve header and its unit tests
- new test/test_host/test_pid.c with convergence, bounds, manual-mode,
  and sample-time gating coverage (467 tests pass, +6)
- gitignore .breadboard symlink (local dev convenience)

Bench-observed on 172.16.1.93 (bitaxe-650): autofan correctly outputs
100% because the diode reading sits ~14°C above the AxeOS-reported
temp under identical config — that residual reading delta is a separate
investigation (NVS temp_offset on AxeOS or hardware unit-to-unit), not
the autofan architecture itself, which now matches AxeOS.

Closes TA-315.

* test: cover autofan setters and remaining PI... (continued)

705 of 840 branches covered (83.93%)

Branch coverage included in aggregate %.

133 of 137 new or added lines in 3 files covered. (97.08%)

1613 of 1640 relevant lines covered (98.35%)

253670.11 hits per line