decentraland / comms-gatekeeper / 25122928001

85%

main: 85%

Pull #259

github

fix: address PR review feedback

- feature-flags.ts: replace .replace('\\n', '') with .replace(/\\n/g, '')
  so multi-newline variant payloads strip every newline, not just the
  first. Pre-existing bug surfaced during review.
- names.ts: add a comment at the inflightByAddress declaration
  explaining why the LRU cache alone can't dedup overlapping callers
  (cache entries only land post-fetch, so simultaneous misses each
  issue their own POST).
- test/unit/feature-flags.spec.ts: cover the multi-newline payload case
  to lock in the regex fix.
- test/unit/land-lease.spec.ts: cover the new in-flight dedup
  (concurrent getAuthorizations calls share one upstream fetch), the
  stale-cache fallback (fresh fetch fails after TTL expiry → return
  previously cached payload), and the cold-start failure path
  (fetch fails before any cache exists → return empty authorizations).

1049 of 1343 branches covered (78.11%)

Branch coverage included in aggregate %.

100 of 101 new or added lines in 7 files covered. (99.01%)

2959 of 3348 relevant lines covered (88.38%)

43.38 hits per line