decentraland / comms-gatekeeper / 24993564023

85%

push

github

fix: drop local-preview fallback (#257)

* refactor: require sceneId in comms-scene-handler and drop LocalPreview fallback

Tighten early validation so a missing sceneId always returns 400 (previously
only non-LocalPreview paths were rejected), narrowing sceneId to string for
the rest of the handler. With that narrowing in place the nested isLocalPreview
conditional collapses: the preview-${identity} fallback was unreachable under
the post-1e62989 contract and is removed. Adds integration coverage for the
LocalPreview path (happy path, scene-ban skip, missing-sceneId rejection),
which the spec was missing.

* test: strengthen LocalPreview happy-path assertions

Addresses code-review findings on #257:
- Assert on response body.adapter end-to-end (real buildConnectionUrl produces it)
- Verify cast.addPresenter chain via livekit.appendToRoomMetadataArray, mirroring the admin test pattern
- Comment the generateCredentials args[3] positional assertion (4th arg is forPreview)

1018 of 1331 branches covered (76.48%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2848 of 3281 relevant lines covered (86.8%)

41.89 hits per line