decentraland / comms-gatekeeper / 25122685231

85%

main: 85%

Pull #259

github

refactor: centralize names cache management and add negative caching

Restructures src/adapters/names.ts so getNamesFromAddresses is the sole
owner of nameByAddressCache, and starts caching negative results so
addresses the upstream confirms have no profile aren't re-fetched.

- fetchProfileBatch no longer touches the cache; it just parses the
  /profiles response into a map of resolved names. The owning batch in
  getNamesFromAddresses now persists both positive entries (string
  name) and negative entries (null) for every address it owned, so a
  later call for an address with no profile reads the null marker
  instead of issuing a fresh POST.
- nameByAddressCache value type widened from `string` to `string | null`,
  with a header comment explaining the null sentinel.
- Variable names dropped the `lower` / `lowerAddresses` prefixes;
  intermediate maps and locals use `address` / `addresses`. A comment
  at the top of getNamesFromAddresses notes that intermediate state is
  keyed by lowercased addresses while the result preserves caller
  casing, and the loop uses `inputAddress` shadowed by `const address`
  for the lowercased form.
- JSDoc on fetchProfileBatch documenting that the cache is owned
  externally; JSDoc on getNamesFromAddresses describing the three
  layers of dedup.

Adds three test cases to test/unit/names.spec.ts under "and an address
has no profile upstream" verifying the negative-cache behaviour.

1045 of 1343 branches covered (77.81%)

Branch coverage included in aggregate %.

100 of 101 new or added lines in 7 files covered. (99.01%)

2955 of 3348 relevant lines covered (88.26%)

43.25 hits per line