decentraland / comms-gatekeeper / 25115211079

85%

main: 85%

Build Type

Pull #259

github

Committed by LautaroPetaccio

Commit Message

test: cover new caching behaviour across adapters

Adds direct coverage for the previously-untested code introduced in
the caching fixes:

- test/unit/names.spec.ts: getNamesFromAddresses (cache hit/miss/partial,
  mixed-case dedup, in-flight dedup across concurrent callers,
  empty-result error path) and getNameOwner (cache reuse, 404, retry,
  encodeURIComponent of the URL path).
- test/unit/feature-flags.spec.ts: refresh populates both featuresFlagMap
  and variantsMap, getVariants reads from cache without re-querying
  upstream, pre-START isEnabled/getVariants behaviour, refresh-failure
  fallback.

Augments existing suites for behaviours that weren't asserted:

- test/unit/worlds-adapter.spec.ts: cache reuse for fetchWorldActionPermissions
  and fetchWorldSceneEntityMetadataById via the real cachedFetchComponent.
- test/integration/world-component.spec.ts: case-insensitive matching for
  hasWorldStreamingPermission/hasWorldDeployPermission and lowercased
  authAddress in the hasWorldOwnerPermission lambdas URL.
- test/integration/land-component.spec.ts: cache reuse for getLandPermissions
  and getLandOperators, plus mixed-case authAddress sharing the same
  cache entry.

Pull Request Pull Request #259: fix: cache hoisting, dedup, and variant caching across adapters

Coverage Stats

1041 of 1339 branches covered (77.74%)

Branch coverage included in aggregate %.

97 of 98 new or added lines in 7 files covered. (98.98%)

1 existing line in 1 file now uncovered.

2952 of 3345 relevant lines covered (88.25%)

43.07 hits per line