decentraland / lamb2 / 25053009309

83%

main: 83%

Build Type

Pull #462

github

Committed by LautaroPetaccio

Commit Message

fix: address review comments on the new endpoints

p1:
- validate-signature: catch the syntaxerror from request.json() and
  surface it as invalidrequesterror so a malformed body returns 400
  instead of 500. integration test sends '{invalid' and asserts the
  status + 'JSON' message.
- validate-signature: cap authchain length at 10. unauthenticated
  endpoint x per-link eth_call x shared l1provider was a real cost-
  amplification vector. real chains are 2-5 links. unit tests cover
  empty, longer-than-cap, and the happy path within the cap.

p2:
- validate-signature: per-element shape guard on authchain - each
  entry must be an object with string type, payload and signature.
  three new unit tests for non-object element, missing field, and
  wrong field type.
- fetch-items-by-filters: prune deprecated networks - drop ropsten,
  kovan, rinkeby, goerli from l1_networks and mumbai from l2_networks.
  none have appeared in production urns since 2023.
- fetch-items-by-filters: extract the magic 1000 in the collections
  graphql query into max_collections_per_query, with a comment that
  it is independent of the per-item limit.
- wearables-catalog: comment why `remaining >= 0` is inclusive of
  zero - off-chain exactly filling the limit still requires one
  on-chain probe to detect hasmore.
- items-by-owner: stop echoing the raw collectionid in the
  invalidrequesterror message - describe the constraint instead.
- items-by-owner: drop the dead `?? undefined` on definitions[i],
  the array element is already typed t | undefined.

caught a real bug in the array body case while writing the array
test - typeof [] === 'object' so the original check let arrays
through to the authchain guard. the new check rejects them up-front
with the right message.

Pull Request Pull Request #462: feat: implement legacy lambdas endpoints in lamb2

Coverage Stats

729 of 973 branches covered (74.92%)

Branch coverage included in aggregate %.

212 of 215 new or added lines in 10 files covered. (98.6%)

5 existing lines in 1 file now uncovered.

2032 of 2353 relevant lines covered (86.36%)

40.68 hits per line