decentraland / lamb2 / 25015854026

83%

main: 83%

Build Type

Pull #462

github

Committed by LautaroPetaccio

Commit Message

fix: tighten validate-signature body checks and short-circuit base avatar filter

three small follow-ups from a review pass:

- validate-signature: the original `!raw || typeof raw !== 'object'`
  check let arrays through (typeof [] === 'object'), causing array
  bodies to fall to the authchain check and surface a confusing
  error. now explicitly rejects arrays so the 'request body must
  be a json object' error reaches the client. caught by the new
  array-body unit test.
- validate-signature: cover the body-shape branches (non-object,
  array, null, missing/non-array authchain, non-string timestamp,
  non-string signedmessage) - 6 new tests.
- wearables-catalog: replace the inline wearableentitymetadata
  alias with the actual wearable type from @dcl/schemas, removing
  one cast.
- wearables-catalog: pass max-results through to filterandextract-
  basewearables and reorder filter -> sort -> slice -> extract so
  extractwearabledefinitionfromentity only runs on items the caller
  will actually use. with ~250 base avatars and broad filters this
  bounds the wasted work to limit+1 extractions instead of up to
  the full list.

Pull Request Pull Request #462: feat: implement legacy lambdas endpoints in lamb2

Coverage Stats

721 of 965 branches covered (74.72%)

Branch coverage included in aggregate %.

199 of 202 new or added lines in 10 files covered. (98.51%)

5 existing lines in 1 file now uncovered.

2019 of 2340 relevant lines covered (86.28%)

40.82 hits per line