IJHack / QtPass / 25008316612

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: address review nits — git cp comment, dedupe reencrypt disable, this-> (#1198)

Three small follow-ups from the recent review thread:

- getProcessName(GIT_COPY) returns "git cp" — ImitatePass::Copy literally
  shells `git cp` (a git-extras subcommand), so the label matches the
  actual invocation. Restoring the explanation comment that was on this
  case before c9a1c8c41 reverted the label from "git add" back to
  "git cp": the label is honest about what runs, but stock-git users
  without git-extras will see the "'cp' is not a git command" error
  surfaced in the process output panel.

- reencryptPath() inlined the same two disable lines that
  startReencryptPath() has, with a comment that openly cross-referenced
  the duplication ("use same method as startReencryptPath"). Replace
  with a direct call. ImitatePass::reencryptPath emits startReencryptPath
  asynchronously and the connected slot will re-run this, but
  setEnabled(false) is idempotent so the duplicate is harmless — kept
  the preemptive disable behaviour, just deduped the lines.

- keygenDialog had four `this->keygenDialog` accesses and one bare
  reference (line 1176). Drop the `this->` prefix on the four for
  consistency with the bare access.

Coverage Stats

0 of 5 new or added lines in 2 files covered. (0.0%)

9 existing lines in 1 file now uncovered.

1854 of 6618 relevant lines covered (28.01%)

27.1 hits per line