IJHack / QtPass / 25000837006
55%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 72
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 28.01% (+0.4%) from 27.572%
25000837006

push

github

web-flow 
test: cover storemodel drop dispatch & MIME round-trip (#239) (#1196)

* test: cover storemodel drop dispatch & MIME round-trip (#239)

#239's drag-and-drop landed in #245 (2016) and the user-stories there
have all been satisfied by the current canDropMimeData / dropMimeData /
executeDropAction code path, but that surface had no unit coverage.
Adding 9 cases to tst_storemodel:

- canDropMimeData rejection paths: null mime, wrong format, empty
  encoded payload, column > 0.
- canDropMimeData allow-paths matching the #239 BDD spec: dir-on-dir,
  file-on-dir, file-on-file. Plus the one combination the spec
  explicitly disallows: dir-on-file.
- MIME round-trip via QDataStream operator<< / operator>>: file kind
  preserves kind+path; directory kind preserves kind+path; an
  unrecognised kind byte resolves to ItemKind::Unknown rather than
  aliasing onto a real kind (decode-safety guarantee).

To make the operators reachable from tests, declare them in
storemodel.h alongside the dragAndDropInfoPasswordStore struct (they
were defined in storemodel.cpp without a header declaration). The
declaration also gives Doxygen something to attach the contract docs
to — the encode/decode invariants live there now.

* test: replace Q_ASSERT in DropFixture with QVERIFY2

Q_ASSERT compiles out under -DQT_NO_DEBUG (which the test build
defines), so a filesystem setup failure in the fixture would silently
produce a half-built fixture and surface as confusing downstream
assertion failures instead of one clear "QFile::open failed" /
"QDir::mkdir failed" message.

QVERIFY2 stays active in release builds and attributes the failure
(with an explanatory string) to whichever test was instantiating the
fixture.

* test: return std::unique_ptr<QMimeData> from makeMimeData helper

The helper's raw owning return forced every call site to remember to
wrap the result in QScopedPointer. Returning std::unique_ptr makes
ownership transfer explicit at the function signature, eliminates the
... (continued)

1854 of 6619 relevant lines covered (28.01%)

27.09 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25000837006.1 72
28.01
 GitHub Action Run
Source Files on build 25000837006