lsm / neokai / 25008225399

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(space): skip redundant merge approval when human already approved (#1668)

* fix(space): skip redundant merge approval when human already approved

When a human approves a task in review, the post-approval merge template
was asking them to approve the merge a second time (step 2 gated on
autonomy_level < 4 alone). Add approval_source == "auto" check so that
human-approved tasks merge directly without the redundant prompt.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): use != "human" instead of == "auto" for approval_source check

SpaceApprovalSource is 'human' | 'auto_policy' | 'agent' — there is no
"auto" value. The previous condition would never match, silently skipping
step 2 for all cases. Using != "human" correctly covers both auto_policy
and agent variants.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): update stale file header comment for approval_source values

The header claimed 'end_node' | 'human_review' but SpaceApprovalSource
is actually 'human' | 'auto_policy' | 'agent'. Update to match reality.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): remove "run tests" from reviewer prompt (gate already requires CI)

The code-ready-gate already requires all CI tests to pass before the
reviewer is activated, so telling the reviewer to run tests is redundant
and wastes time.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

9437 of 12638 branches covered (74.67%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

67180 of 79701 relevant lines covered (84.29%)

303.09 hits per line