lsm / neokai / 25006517222

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(daemon): make AskUserQuestion survive daemon restart and clean up dead sessions (#1659)

* fix(daemon): make AskUserQuestion survive daemon restart and clean up dead sessions (#138)

Before this change, a daemon restart while a session was in
`waiting_for_input` left the question card as a dead-end: the persisted
state still rendered the form, but the in-memory `pendingResolver` was
gone, so Submit/Skip threw "No pending question" and the user had no
way out short of refreshing the whole session.

This change adds three coordinated fixes:

- **Restart-survival path on the handler** — `AskUserQuestionHandler`
  keeps a `queuedAnswers` map keyed by toolUseId. When Submit/Skip RPCs
  arrive after the in-memory resolver is gone, the handler stores a
  PermissionResult, transitions out of waiting_for_input, and injects a
  synthetic `tool_result` user message into the streaming queue so the
  resumed SDK query can continue. If the SDK re-issues the
  AskUserQuestion call instead of treating the prior tool_use as
  resolved, `createCanUseToolCallback` consumes the queued answer
  immediately. Both halves are intentionally redundant.

- **Orphan cleanup on session death** — new `markQuestionOrphaned()`
  flips the persisted question to a `cancelled` ResolvedQuestion with
  `cancelReason='agent_session_terminated'`. Wired into SpaceRuntime
  Step 1 (force-completion / block) and Step 1.5 (auto-complete) so a
  force-completed session shows "Question cancelled — agent session
  ended" rather than vanishing.

- **Step 1.5 guard for waiting_for_input** — the auto-complete loop
  now spares sessions whose ProcessingState is `waiting_for_input`
  (the agent is not stuck — a human is). Long-term fix is to remove
  Step 1.5 entirely; this is the interim guard.

New telemetry: `question.orphaned`, `question.injected_as_tool_result`.

UI: `QuestionPrompt` accepts a `cancelReason` prop and renders the
orphan case distinctly. `useSessionQuestionState` already thread... (continued)

Coverage Stats

9438 of 12638 branches covered (74.68%)

Branch coverage included in aggregate %.

189 of 214 new or added lines in 5 files covered. (88.32%)

3 existing lines in 1 file now uncovered.

67181 of 79701 relevant lines covered (84.29%)

303.09 hits per line